Pydantic V2 support #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Pydantic V2 support
fcurella
requested changes
Sep 20, 2023
fcurella
reviewed
Sep 20, 2023
| @@ -169,6 +169,16 @@ def validate(cls, v: str) -> Self: | |||
| raise ValueError("invalid data-uri format") | |||
| return m | |||
|
|
|||
| @classmethod | |||
| def __get_pydantic_json_schema__(cls, core_schema: Any, handler: Any) -> Any: | |||
There was a problem hiding this comment.
shouldn't core_schema have type Mapping[str, Any], as in pydantic_core?
fcurella
reviewed
Sep 20, 2023
fcurella
reviewed
Sep 20, 2023
fcurella
reviewed
Sep 20, 2023
| == '{"content": "data:text/plain;charset=utf-8;base64,VGhlIHF1aWNrIGJyb3duIGZveCBqdW1wZWQgb3ZlciB0' | ||
| 'aGUgbGF6eSBkb2cu"}' | ||
| instance.__getattr__(func_json)() | ||
| == '{"content":"data:text/plain;charset=utf-8;base64,VGhlIHF1aWNrIGJyb3duIGZveCBqdW1wZWQgb3ZlciB0aGUgbGF6eSBkb2cu"}' |
There was a problem hiding this comment.
I don't know how to test for this edge case
- Updated the test suite in 'tests/test_pydantic.py' to enhance compatibility with various Pydantic versions.
- Previously, the test suite attempted to access attributes 'model_dump_json' and 'model_dump' without exception handling, potentially causing test failures with specific Pydantic versions.
- In this commit, we've improved compatibility by handling AttributeError exceptions and determining the appropriate functions ('json' and 'dict') to use based on the available Pydantic version.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Pydantic V2 support